On Wed, Mar 22, 2017 at 11:10:23AM +0100, Eelco Chaudron wrote: > The "ovs-appctl dpif-netdev/pmd-rxq-show" and "ovs-appctl > dpif-netdev/pmd-stats-show" commands show their output per core_id, > sorted on the hash location. My OCD was kicking in when using these > commands, hence this change to display them in natural core_id order. > > In addition I had to change a test case that would fail if the cores > where not in order in the hash list. This is due to OVS assigning > queues to cores based on the order in the hash list. The test case now > checks if any core has the set of queues in the given order. > > Manually tested this on my setup, and ran clang-analyze. > > Signed-off-by: Eelco Chaudron <[email protected]>
This should be helpful, thanks. sorted_poll_thread_list() worries me. It calls cmap_count() and then uses CMAP_FOR_EACH to iterate the list and assumes (asserts, even) that the number of pmds does not change during iteration. Is this safe? If it is, then a clearer comment would be helpful, and it would be wise to have an assertion for the exact number at the end. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
