> On Apr 14, 2017, at 8:58 PM, Ben Pfaff <[email protected]> wrote: > > On Thu, Apr 13, 2017 at 06:31:06PM -0700, Jarno Rajahalme wrote: >> Commit 21b2fa617126 ("ofp-parse: Allow match field names in actions >> and brackets in matches.") added support for matching a consecutive >> set of bits with the [x..y]=z format, but the copying of the parsed >> value ('z') to the match was done from a wrong offset, so that the >> actual value matched would be incorrect. >> >> Fix this and add a test case preventing regression in future. >> >> Fixes: 21b2fa617126 ("ofp-parse: Allow match field names in actions and >> brackets in matches.") >> Signed-off-by: Jarno Rajahalme <[email protected]> > > Oops, thanks for the fix! > > Should the test try a multibit match too, for completeness? >
Pushed to master and branch-2.7 with an additional multibit match. Thanks for the review! Jarno > Acked-by: Ben Pfaff <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
