On 19 April 2017 at 16:54, Jarno Rajahalme <[email protected]> wrote: > Upstream commit: > > commit b768b16de58d5e0b1d7c3f936825b25327ced20c > Author: Jarno Rajahalme <[email protected]> > Date: Tue Mar 28 11:25:26 2017 -0700 > > openvswitch: Fix refcount leak on force commit. > > The reference count held for skb needs to be released when the skb's > nfct pointer is cleared regardless of if nf_ct_delete() is called or > not. > > Failing to release the skb's reference cound led to deferred conntrack > cleanup spinning forever within nf_conntrack_cleanup_net_list() when > cleaning up a network namespace: > > kworker/u16:0-19025 [004] 45981067.173642: sched_switch: > kworker/u16:0:19025 [120] R ==> rcu_preempt:7 [120] > kworker/u16:0-19025 [004] 45981067.173651: kernel_stack: <stack trace> > => ___preempt_schedule (ffffffffa001ed36) > => _raw_spin_unlock_bh (ffffffffa0713290) > => nf_ct_iterate_cleanup (ffffffffc00a4454) > => nf_conntrack_cleanup_net_list (ffffffffc00a5e1e) > => nf_conntrack_pernet_exit (ffffffffc00a63dd) > => ops_exit_list.isra.1 (ffffffffa06075f3) > => cleanup_net (ffffffffa0607df0) > => process_one_work (ffffffffa0084c31) > => worker_thread (ffffffffa008592b) > => kthread (ffffffffa008bee2) > => ret_from_fork (ffffffffa071b67c) > > Fixes: dd41d33f0b03 ("openvswitch: Add force commit.") > Reported-by: Yang Song <[email protected]> > Signed-off-by: Jarno Rajahalme <[email protected]> > Acked-by: Joe Stringer <[email protected]> > Signed-off-by: David S. Miller <[email protected]> > > Signed-off-by: Jarno Rajahalme <[email protected]>
Acked-by: Joe Stringer <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
