Looks correct to me. Acked-by: Jarno Rajahalme <ja...@ovn.org>
> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech> > wrote: > > When bridges destroyed, which stp enabled, you can > still get stp info via the command 'ovs-appctl stp/show'. > And the rstp is also in the same case. We should unref > them. The rstp/stp ports have been unregistered via > 'ofproto_port_unregister' function when ports destroyed. > We will unref rstp/stp struct in the 'destruct' of > ofproto-dpif provider. > > Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> > --- > ofproto/ofproto-dpif.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 523adad..4beacda 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -1494,6 +1494,8 @@ destruct(struct ofproto *ofproto_) > hmap_destroy(&ofproto->bundles); > mac_learning_unref(ofproto->ml); > mcast_snooping_unref(ofproto->ms); > + stp_unref(ofproto->stp); > + rstp_unref(ofproto->rstp); > > sset_destroy(&ofproto->ports); > sset_destroy(&ofproto->ghost_ports); > -- > 1.8.3.1 > > > > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
