On 24 April 2017 at 14:03, Greg Rose <[email protected]> wrote: > On Mon, 2017-04-24 at 13:50 -0700, Jarno Rajahalme wrote: >> Upstream commit: >> >> commit 120645513f55a4ac5543120d9e79925d30a0156f >> Author: Jarno Rajahalme <[email protected]> >> Date: Fri Apr 21 16:48:06 2017 -0700 >> >> openvswitch: Add eventmask support to CT action. >> >> Add a new optional conntrack action attribute OVS_CT_ATTR_EVENTMASK, >> which can be used in conjunction with the commit flag >> (OVS_CT_ATTR_COMMIT) to set the mask of bits specifying which >> conntrack events (IPCT_*) should be delivered via the Netfilter >> netlink multicast groups. Default behavior depends on the system >> configuration, but typically a lot of events are delivered. This can be >> very chatty for the NFNLGRP_CONNTRACK_UPDATE group, even if only some >> types of events are of interest. >> >> Netfilter core init_conntrack() adds the event cache extension, so we >> only need to set the ctmask value. However, if the system is >> configured without support for events, the setting will be skipped due >> to extension not being found. >> >> Signed-off-by: Jarno Rajahalme <[email protected]> >> Reviewed-by: Greg Rose <[email protected]> >> Acked-by: Joe Stringer <[email protected]> >> Signed-off-by: David S. Miller <[email protected]> >> >> Signed-off-by: Jarno Rajahalme <[email protected]> > > On patches that have already been reviewed, accepted by the community > and pushed upstream do we still ACK those here on the OVS dev list?
It's worth a last round of review just in case something was missed upstream, but particularly if there are any changes within datapath/linux/compat/* or outside datapath/, as those may not have received review. The datapath backport compatibility changes need to work across a variety of different kernels so that's an easy vector to introduce bugs. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
