On Thu, 2017-04-27 at 04:02 -0700, William Tu wrote:
> Before the patch, when users create bridge named "default", although
> ovs-vsctl fails but vswitchd in the background will keep retrying it,
> causing the systemd-udev to reach 100% cpu utilization. The reason is
> due to frequent calls into kernel's register_netdevice function,
> which will invoke several kernel elements who has registered on the
> netdevice notifier chain. One of the notifier, the inetdev_event rejects
> this devname and register_netdevice fails. The patch prohibits creating
> "default" bridge name.
>
> VMWare-BZ: #1842388
> Signed-off-by: William Tu <u9012...@gmail.com>
> ---
> vswitchd/bridge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index ebb6249416fa..e8a22f82e1d6 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -1710,7 +1710,8 @@ add_del_bridges(const struct ovsrec_open_vswitch *cfg)
> static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
> const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
>
> - if (strchr(br_cfg->name, '/') || strchr(br_cfg->name, '\\')) {
> + if (strchr(br_cfg->name, '/') || strchr(br_cfg->name, '\\')
> + || !strcmp(br_cfg->name, "default")) {
> /* Prevent remote ovsdb-server users from accessing arbitrary
> * directories, e.g. consider a bridge named "../../../etc/".
> *
Acked-by: Greg Rose <gvrose8...@gmail.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
