On Tue, Apr 18, 2017 at 07:13:26PM +0000, Bodireddy, Bhanuprakash wrote: > >On Sun, Mar 12, 2017 at 05:33:27PM +0000, Bhanuprakash Bodireddy wrote: > >> The sorted subtable ranking patch introduced a classifier instance per > >> ingress port with its subtables ranked on the frequency of hits. The > >> pmd thread can have more classifier instances now and solely depends > >> on the number of ingress ports currently handled by the pmd thread. > >> > >> Signed-off-by: Bhanuprakash Bodireddy > >> <[email protected]> > > > >Thank you for improving comments! > > > >I'm not the right person to review this patch, but from a process > >perspective I > >find myself wondering whether it corrects a comment that was already wrong > >before the beginning of the series (in which case it is fine as-is) or > >whether it > >only needs correction following the series (in which case it should be folded > >into whichever patch made it incorrect). > > > >Thanks again! > > Hi Ben, > Please note that the comments were right initially but after the "subtable > ranking" feature got introduced the comments needed correction. The subtable > ranking patch series got merged a while ago but this particular comment > wasn't fixed then. I happened to find this during code inspection. What's > the best way to handle this now?
Ah. The ideal process would be to send this as an independent patch not part of a series, and to add a Fixes: tag that cites the commit that made the comment incorrect. That should make it clear to everyone what's going on. Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
