Just one small nit if you want to fix it (but not necessarily needed): no newline at the end of file. This is because editing the file via the GUI strips down eol.
Acked-by: Alin Gabriel Serdean <[email protected]> > -----Original Message----- > From: [email protected] [mailto:ovs-dev- > [email protected]] On Behalf Of Shashank Ram > Sent: Tuesday, May 16, 2017 10:57 PM > To: [email protected] > Subject: [ovs-dev] [PATCH v2] datapath-windows: Set Version correctly for > OVSExt > > - Previously, the 'Version' property passed to MSBuild > was not being passed to the RcComplile section. To > use the value of 'Version' property in the rc file, > it needs to be passed. > > - Adds a macro to convert the Version to a string literal. > Previously, the Version was simply being converted > to a literal text 'Version' instead of the the version > number passed using the 'Version' property to MSBuild. > > Signed-off-by: Shashank Ram <[email protected]> > --- > <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" /> -</Project> > \ No newline at end of file > +</Project> > -- > 2.6.2 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
