Thanks for identifying and fixing this.
Acked-by: Anand Kumar <kumaran...@vmware.com>
Regards,
Anand Kumar
On 5/17/17, 6:54 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin
Serdean" <ovs-dev-boun...@openvswitch.org on behalf of
aserd...@cloudbasesolutions.com> wrote:
Found using static analysis tools.
Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>
---
datapath-windows/ovsext/IpFragment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/IpFragment.c
b/datapath-windows/ovsext/IpFragment.c
index 675c32e..0874cb9 100644
--- a/datapath-windows/ovsext/IpFragment.c
+++ b/datapath-windows/ovsext/IpFragment.c
@@ -343,7 +343,7 @@ OvsProcessIpv4Fragment(POVS_SWITCH_CONTEXT
switchContext,
}
POVS_FRAGMENT_LIST next = entry->head;
POVS_FRAGMENT_LIST prev = entry->tail;
- if (prev != NULL || prev->offset < offset) {
+ if (prev != NULL && prev->offset < offset) {
next = NULL;
goto found;
}
--
2.10.2.windows.1
_______________________________________________
dev mailing list
d...@openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=CWdGnCwQAqL4DBYA2RcH6SVyKhJMwEh0s9_AwzmByns&s=oNiDelVhtnHmgoVawTP5ysWACw1yvHXAtTxiQ-A6KnU&e=
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
