Usually I wait for someone who knows DPDK better to review DPDK patches, but I agree that this one is trivial. I applied it to master. Thank you for your contribution!
On Tue, May 16, 2017 at 07:50:00AM +0000, Szczerbik, PrzemyslawX wrote: > Hi, > > Any comments on this change? It's really trivial patch, which has been > sitting in patchwork for some time now. > Is there anything that I can do to expedite the review process? > > Kind regards, > Przemek > > > -----Original Message----- > > From: [email protected] [mailto:ovs-dev- > > [email protected]] On Behalf Of Przemyslaw Szczerbik > > Sent: Friday, April 28, 2017 10:52 AM > > To: [email protected] > > Subject: [ovs-dev] [PATCH] netdev-dpdk: add support for rx_multicast_packets > > counter > > > > This patch enables already implemented ifInMulticastPkts counter in sFlow > > for > > DPDK interfaces. Metric is retrieved from DPDK by using extended statistic > > API > > and stored in 'multicast' member of netdev_stats structure, which represents > > number of incoming packets that were addressed to a multicast address. > > > > Signed-off-by: Przemyslaw Szczerbik <[email protected]> > > --- > > lib/netdev-dpdk.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > > index ddc651b..2de9d26 100644 > > --- a/lib/netdev-dpdk.c > > +++ b/lib/netdev-dpdk.c > > @@ -118,6 +118,7 @@ BUILD_ASSERT_DECL((MAX_NB_MBUF / > > ROUND_DOWN_POW2(MAX_NB_MBUF/MIN_NB_MBUF)) > > #define XSTAT_TX_1024_TO_1522_PACKETS "tx_size_1024_to_1522_packets" > > #define XSTAT_TX_1523_TO_MAX_PACKETS "tx_size_1523_to_max_packets" > > > > +#define XSTAT_RX_MULTICAST_PACKETS "rx_multicast_packets" > > #define XSTAT_TX_MULTICAST_PACKETS "tx_multicast_packets" > > #define XSTAT_RX_BROADCAST_PACKETS "rx_broadcast_packets" > > #define XSTAT_TX_BROADCAST_PACKETS "tx_broadcast_packets" > > @@ -1996,6 +1997,8 @@ netdev_dpdk_convert_xstats(struct netdev_stats > > *stats, > > stats->tx_1024_to_1522_packets = xstats[i].value; > > } else if (strcmp(XSTAT_TX_1523_TO_MAX_PACKETS, names[i].name) == > > 0) { > > stats->tx_1523_to_max_packets = xstats[i].value; > > + } else if (strcmp(XSTAT_RX_MULTICAST_PACKETS, names[i].name) == 0) > > { > > + stats->multicast = xstats[i].value; > > } else if (strcmp(XSTAT_TX_MULTICAST_PACKETS, names[i].name) == 0) > > { > > stats->tx_multicast_packets = xstats[i].value; > > } else if (strcmp(XSTAT_RX_BROADCAST_PACKETS, names[i].name) == 0) > > { > > -- > > 1.9.3 > > > > -------------------------------------------------------------- > > Intel Research and Development Ireland Limited > > Registered in Ireland > > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > > Registered Number: 308263 > > > > > > This e-mail and any attachments may contain confidential material for the > > sole > > use of the intended recipient(s). Any review or distribution by others is > > strictly prohibited. If you are not the intended recipient, please contact > > the > > sender and delete all copies. > > > > _______________________________________________ > > dev mailing list > > [email protected] > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > -------------------------------------------------------------- > Intel Research and Development Ireland Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > Registered Number: 308263 > > > This e-mail and any attachments may contain confidential material for the sole > use of the intended recipient(s). Any review or distribution by others is > strictly prohibited. If you are not the intended recipient, please contact the > sender and delete all copies. > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
