On 19 May 2017 at 06:22, Eric Garver <[email protected]> wrote: > On Thu, May 18, 2017 at 07:48:56PM -0700, Greg Rose wrote: >> On Thu, 2017-05-18 at 15:53 -0700, Joe Stringer wrote: >> > On 18 May 2017 at 15:35, Greg Rose <[email protected]> wrote: >> > > On Thu, 2017-05-18 at 16:10 -0400, Eric Garver wrote: >> > >> This series adds support for the creation of tunnels using the rtnetlink >> > >> interface. This will open the possibility for new features and flags on >> > >> those >> > >> vports without the need to change vport compatibility code. >> > >> >> > >> Support for STT and LISP have not been added because these are not >> > >> upstream yet, >> > >> so we don't know how the interface will be like upstream. And there are >> > >> no >> > >> features in the current drivers right now we could make use of. >> > >> >> > >> Note: This work originally started by Thadeu Lima de Souza Cascardo. >> > >> >> > >> Note: There is a known failure for GENEVE tunnels using rtnetlink on >> > >> newer >> > >> kernels. This is being addressed with a separate kernel fix. The >> > >> fallback to >> > >> compat will work however. >> > > >> > > I've applied these patches for testing and review and I get these errors >> > > when I run make check on a 4.12-rc1 kernel: >> > > 783: tunnel-push-pop.at:3 tunnel_push_pop - action >> > > 784: tunnel-push-pop.at:191 tunnel_push_pop - packet_out >> > > 785: tunnel-push-pop.at:229 tunnel_push_pop - underlay bridge match >> > > 786: tunnel-push-pop-ipv6.at:3 tunnel_push_pop_ipv6 - action >> > > >> > > Are these the known failures? Was there something in the compat that >> > > needs fixing? I'm sort of new to this so please excuse any obvious >> > > ignorance showing. >> > > >> > > I've downloaded the 4.9.23 kernel and will try against that next. >> > >> > Hmm, I've tried it on my dev box with kernel 4.9.11 and I don't see >> > any failures. >> > >> > If these reliably fail, could you post the testsuite.log? >> >> It's the 4.12-rc1 kernel. He mentions known failures on newer kernels. >> > > The known failure is for the "check-kernel" GENEVE tests. It affects the > rtnetlink interface, but it will fallback to the compat interface and > therefore the test case should still pass (assuming vport-geneve.ko is > available). > > I just ran "check" on a RHEL-7 based VM with a 4.12-rc1 kernel. The > tests you mention above passed. > > Are you still seeing failures after a re-run?
I spoke to Greg offline and it appears that the issues he's observing are particular to his setup, so we can proceed with this patch series separately. I don't think Travis-CI, you or I are seeing any remaining issues in the series as is. Thanks, I applied this series to master. Nice to have this in! I also assembled a short cleanup series to go on top, would you mind taking a look? https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/332675.html Cheers, Joe _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
