On Sun, May 21, 2017 at 6:35 PM, <nusid...@redhat.com> wrote: > From: Numan Siddique <nusid...@redhat.com> > > start action returns OCF_RUNNING_MASTER in certain scenarios. > But as per the OCF guidelines, status code OCF_RUNNING_MASTER shoud > be returned only in monitor action [1]. > > Whenever the start action returns OCF_RUNNING_MASTER, it is observed > in the testing that, pacemaker stops the ovsdb-server ocf resource > in that node. This patch fixes this issue by returning OCF_SUCESS in > such cases. > > stop action returns OCF_RUNNING_MASTER if the ovsdb-servers are > running as master. But as per the OCF guidelines [2], stop action > should only return OCF_SUCCESS. If any other code is returned, > pacemaker cluster would block that resource in that node. > > This patch fixes this issue by stopping the ovsdb-servers when they > are running as masters (which is the expected case) and returns > OCF_SUCCESS. > > [1] - > http://www.linux-ha.org/doc/dev-guides/_literal_ocf_running_master_literal_8.html > [2] - http://www.linux-ha.org/doc/dev-guides/_literal_stop_literal_action.html > > CC: Andy Zhou <az...@ovn.org> > Signed-off-by: Numan Siddique <nusid...@redhat.com>
Thanks for the fixes! Both patches look reasonable to me. I pushed them to master. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
