Seems wise, even if not strictly required. Found by Coverity.
Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763099&defectInstanceId=4305325&mergedDefectId=180413&fileStart=251&fileEnd=269 Signed-off-by: Ben Pfaff <[email protected]> --- tests/test-conntrack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test-conntrack.c b/tests/test-conntrack.c index 4213f5c2e5a7..4c35b3a2c32c 100644 --- a/tests/test-conntrack.c +++ b/tests/test-conntrack.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015 Nicira, Inc. + * Copyright (c) 2015, 2017 Nicira, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -237,6 +237,7 @@ test_pcap(struct ovs_cmdl_context *ctx) dp_packet_delete_batch(batch, true); } conntrack_destroy(&ct); + fclose(pcap); } static const struct ovs_cmdl_command commands[] = { -- 2.10.2 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
