On Fri, 2017-05-26 at 16:07 -0700, Ben Pfaff wrote:
> Found by Coverity.
> 
> Reported-at: 
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762909&defectInstanceId=4305311&mergedDefectId=180415
> Signed-off-by: Ben Pfaff <[email protected]>
> ---
>  lib/dpctl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/dpctl.c b/lib/dpctl.c
> index 11be85706db5..c0da3108943d 100644
> --- a/lib/dpctl.c
> +++ b/lib/dpctl.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 
> Nicira, Inc.
> + * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 
> Nicira, Inc.

OK, last time I'll comment on this I swear!  :)

Better something like Copyright (c) 2008-2017

Otherwise someday the line will be really long.

Thanks!

- Greg


>   *
>   * Licensed under the Apache License, Version 2.0 (the "License");
>   * you may not use this file except in compliance with the License.
> @@ -806,6 +806,7 @@ dpctl_dump_flows(int argc, const char *argv[], struct 
> dpctl_params *dpctl_p)
>                                           &names_portno);
>          if (err) {
>              dpctl_error(dpctl_p, 0, "Failed to parse filter (%s)", err);
> +            free(err);
>              error = EINVAL;
>              goto out_dpifclose;
>          }



_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to