On Fri, May 26, 2017 at 09:31:19AM -0700, Greg Rose wrote:
> On Fri, 2017-05-26 at 08:46 -0700, Ben Pfaff wrote:
> > It's becoming more common that OSes include "ip" but not "ifconfig", so
> > it's best to avoid using the latter.  This commit removes most references
> > to "ifconfig" and replaces them by "ip".  It also adds a build-time check
> > to make it harder to introduce new uses of "ifconfig".
> > 
> > Signed-off-by: Ben Pfaff <[email protected]>
> 
> I pointed out the places below where the link needs to be brought up
> explicitly after setting an ip address.
> 
> I applaud the purpose of this patch - ifconfig has been deprecated for a
> long time now.
> 
> Thanks Ben!

Thanks a lot for the review.  I fixed what you pointed out and posted a
v4:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/333131.html
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to