On Tue, 2017-05-30 at 10:39 -0700, Ben Pfaff wrote: > On Tue, May 30, 2017 at 10:30:59AM -0700, Greg Rose wrote: > > On Tue, 2017-05-30 at 10:29 -0700, Ben Pfaff wrote: > > > On Tue, May 30, 2017 at 10:04:55AM -0700, Greg Rose wrote: > > > > On Tue, 2017-05-30 at 09:31 -0700, Ben Pfaff wrote: > > > > > It's becoming more common that OSes include "ip" but not "ifconfig", > > > > > so > > > > > it's best to avoid using the latter. This commit removes most > > > > > references > > > > > to "ifconfig" and replaces them by "ip". It also adds a build-time > > > > > check > > > > > to make it harder to introduce new uses of "ifconfig". > > > > > > > > > > There are important differences between "ifconfig" and "ip": > > > > > > > > > > - An "ifconfig" command that sets an IP address also brings the > > > > > interface > > > > > up, but a similar "ip addr add" command does not, so it is often > > > > > necessary > > > > > (or at least precautionary) to add an "ip link set <dev> up" > > > > > command. > > > > > > > > > > - "ifconfig" can infer a netmask from an IP adddress, but "ip" always > > > > > assumes /32 if none is given. > > > > > > > > > > - "ifconfig" with address 0.0.0.0 removes any configured IP address, > > > > > but > > > > > "ip addr add" does not, so "ifconfig <dev> 0.0.0.0" must be > > > > > replaced by > > > > > "ip addr del" or "ip addr flush". > > > > > > > > > > Signed-off-by: Ben Pfaff <[email protected]> > > > > > > > > A couple of typos below that you can fix on push but otherwise looks > > > > good. > > > > > > > > Thanks! > > > > > > Are you decently set up to test this (the python bits)? I don't have a > > > good setup at the moment. > > > > Sure. I just started another test that will take a bit to complete but I > > can get to it today. > > Thanks a lot.
Passes 'make check'. 2355 tests were successful. 1 test was skipped. The one test skipped was this one: 129. daemon --service (daemon.at:167): skipped (daemon.at:169) 1 test was skipped. I'll look into it. But for Python 2 and Python 3 everything was fine. Passed a Travis build too. https://travis-ci.org/gvrose8192/ovs-experimental/builds/237694694 Thanks, - Greg _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
