Hi Ben, Thanks for catching it. I will add "--enable-Werror" next time.
BTW, I would like to submit another patch to use sendmmsg to replace sendmsg. Sendmmsg get more benefit on throughput(my draft testing show 100% improvment). Do you think it is doable? Thanks Zhenyu Gao 2017-05-31 0:43 GMT+08:00 Ben Pfaff <[email protected]>: > On Mon, May 29, 2017 at 04:08:03AM +0000, Zhenyu Gao wrote: > > 1. We don't need to initialize sock,msg in before calling sendmsg each > time > > Just initialize them before the loop, it can reduce cpu cycles. > > > > Signed-off-by: Zhenyu Gao <[email protected]> > > Thanks for working on OVS. > > GCC reports the following, and I think that it is right. Can you take a > look? > > ../lib/netdev-linux.c:1247:20: error: 'sock' may be used uninitialized in > this function [-Werror=maybe-uninitialized] > retval = sendmsg(sock, &msg, 0); > ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
