On Wed, May 17, 2017 at 10:11:30PM +0530, [email protected] wrote:
> From: SatyaValli <[email protected]>
>
> OpenFlow 1.5 introduces the Extensible Statistics (OXS) by redefining the
> existing
> flow entry statistics with OXS Fields.
> This Patch provides implementation for OXS fields encoding in TLV format.
>
> To support this implementation below two messages are newly added
>
> OFPST_OXS_FLOW_STATS_REQUEST
> OFPST_OXS_FLOW_STATS_REPLY
> OFPST_OXS_AGGREGATE_STATS_REQUEST
> OFPST_OXS_AGGREGATE_STATS_REPLY
> OFPST_FLOW_REMOVED
>
> As per the openflow specification-1.5, this enhancement should take place
> on the existing flow entry statistics with the OXS fields on all the messages
> that carries flow entry statistics.
>
> The current commit adds support for the new feature in flow statistics
> multipart messages,
> aggregate multipart messages and OXS flow statistics support for flow removal
> message.
>
> Some more fields are added to ovs-ofctl dump-flows command to support
> OpenFlow15 OXS stats.
> Below are Commands to display OXS stats field wise
>
> Flow Statistics Multipart
> ovs-ofctl dump-flows -O OpenFlow15 <bridge> oxs-duration
> ovs-ofctl dump-flows -O OpenFlow15 <bridge> oxs-idle_time
> ovs-ofctl dump-flows -O OpenFlow15 <bridge> oxs-packet_count
> ovs-ofctl dump-flows -O OpenFlow15 <bridge> oxs-byte_count
>
> Aggregate Flow Statistics Multipart
> ovs-ofctl dump-aggregate -O OpenFlow15 <bridge> oxs-packet_count
> ovs-ofctl dump-aggregate -O OpenFlow15 <bridge> oxs-byte_count
> ovs-ofctl dump-aggregate -O OpenFlow15 <bridge> oxs-flow_count
This doesn't build:
In file included from ../lib/ox-stat.c:19:
../lib/ox-stat.h:29:48: error: declaration of 'struct ofputil_flow_stats'
will not be visible outside of this function [-Werror,-Wvisibility]
../lib/ox-stat.c:222:20: error: use of undeclared identifier
'oxs_header_map'
../lib/ox-stat.c:223:20: error: use of undeclared identifier
'oxs_name_map'; did you mean 'oxs_ox_map'?
../lib/ox-stat.c:46:24: note: 'oxs_ox_map' declared here
../lib/ox-stat.c:229:26: error: use of undeclared identifier
'oxs_header_map'
../include/openvswitch/hmap.h:101:20: note: expanded from macro
'hmap_insert'
../lib/ox-stat.c:231:26: error: use of undeclared identifier
'oxs_name_map'; did you mean 'oxs_ox_map'?
../include/openvswitch/hmap.h:101:20: note: expanded from macro
'hmap_insert'
../lib/ox-stat.c:46:24: note: 'oxs_ox_map' declared here
../lib/ofp-util.c:10166:13: error: enumeration values
'OFPTYPE_OXS_FLOW_STATS_REQUEST' and 'OFPTYPE_OXS_FLOW_STATS_REPLY' not handled
in switch [-Werror,-Wswitch]
After applying every patch, the tree must build and pass all the tests.
Please fix your patch series to do that and repost it.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
