> On Jun 1, 2017, at 7:01 AM, Ben Pfaff <[email protected]> wrote: > > On Fri, May 19, 2017 at 12:20:39AM -0700, nickcooper-zhangtonghao wrote: >> * This patch will be used for next patch. The 'rstp/show' command, >> which uses the mutex, calls functions which also use the mutex. >> We should init it as a recursive mutex. >> >> * Because of recursive mutex, this patch remove the OVS_EXCLUDED in >> list/rstp.[ch] files. >> >> * Some rstp tests of OvS, which run with ovstest, does not run rstp_init >> in the bridge_init. We should call rstp_init when creating the rstp >> and stp also do that, otherwise tests fail. >> >> Signed-off-by: nickcooper-zhangtonghao <[email protected]> > > I think I'd prefer to add internal versions of functions that don't take > the locks, instead. Did you consider that approach?
The v4 patches has been submitted. We use the internal functions to implement the ‘rstp/show’. http://patchwork.ozlabs.org/patch/769478/ <http://patchwork.ozlabs.org/patch/769478/> http://patchwork.ozlabs.org/patch/769476/ <http://patchwork.ozlabs.org/patch/769476/> http://patchwork.ozlabs.org/patch/769477/ <http://patchwork.ozlabs.org/patch/769477/> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
