> On May 26, 2017, at 8:39 PM, Ben Pfaff <[email protected]> wrote:
> 
> The code in ofputil_decode_port_mod() was originally meant to mask
> the returned 'config' value against 'mask'.  That is, only bits that are
> marked in 'mask' as to be modified can be set to 1-bits in the returned
> 'config' value; it doesn't really entirely make sense otherwise.  The
> actual code to do this was dead, though.  This fixes that problem.
> 
> In a quick skim of callers, I wasn't able to see an actual user-visible
> bug that this fixes.
> 
> Found by Coverity.
> 
> Reported-at: 
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762682&defectInstanceId=4304822&mergedDefectId=180422
> Signed-off-by: Ben Pfaff <[email protected]>

Acked-by: Justin Pettit <[email protected]>

--Justin




_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to