On 09/06/2017 21:37, Flavio Leitner wrote:
On Thu, Jun 08, 2017 at 02:46:22PM +0300, Roi Dayan wrote:
Add tc helper functions to query and manipulate the flower classifier.
Signed-off-by: Paul Blakey <[email protected]>
Co-authored-by: Roi Dayan <[email protected]>
Signed-off-by: Roi Dayan <[email protected]>
Acked-by: Flavio Leitner <[email protected]>
Not sure why SCTP wasn't implemented, but not a blocker either.
Hi Flavio,
I didn't add it because later needed to spread changes across more
commits to support it to the end. planned to do it in a later
commit after the series.
All the other changes took me long enough and I wanted to minimize the
wait.
--- a/lib/tc.c
+++ b/lib/tc.c
[...]
+
+#define JIFFIES_TO_MS(x) (x * 10)
+};
Thanks for fixing this
+static void
+nl_parse_tcf(const struct tcf_t *tm, struct tc_flower *flower)
+{
+ flower->lastused = time_msec() - JIFFIES_TO_MS(tm->lastuse);
+}
+
And this, much better.
+ bs = nl_attr_get_unspec(stats_attrs[TCA_STATS_BASIC], sizeof *bs);
+ put_32aligned_u64(&stats->n_packets, bs->packets);
+ put_32aligned_u64(&stats->n_bytes, bs->bytes);
+int
+tc_dump_flower_start(int ifindex, struct nl_dump *dump)
+{
+ struct ofpbuf request;
+ struct tcmsg *tcmsg;
+
+ tcmsg = tc_make_request(ifindex, RTM_GETTFILTER, NLM_F_DUMP, &request);
+ tcmsg->tcm_parent = TC_H_MAKE(TC_H_CLSACT, TC_H_MIN_INGRESS);
But that went in an opposite direction of the previous patch because
it is used like 5 times and it could be a define in tc.h leaving the TC
details hidden in there.
right. planned to do it but somehow skipped it. I'll be happy
to update this if needed for this series or in a later commit.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
