On Mon, Jun 12, 2017 at 04:21:04PM -0700, Joe Stringer wrote: > On 9 June 2017 at 08:58, Flavio Leitner <[email protected]> wrote: > > The daemon is killed leaving resources behind when a test fails. > > This fixes to first signal the daemon to exit gracefully. > > > > Fixes: 0f28164be02ac ("netdev-linux: make tap devices persistent") > > Suggested-by: Joe Stringer <[email protected]> > > Co-authored-by: Ben Pfaff <[email protected]> > > Signed-off-by: Flavio Leitner <[email protected]> > > --- > > Thanks for the re-spin. Ben, as co-author were you planning to commit this? > > Acked-by: Joe Stringer <[email protected]> > > As a side note, in the case that the "kill" gets hit, there will be > state left lying around such as tap devices. To truly handle that, we > would have to consider keeping track of all of the bridges and devices > configured during the tests (or prefixing them with a common prefix > like "ovs_" or "at_") then blindly clearing these out in this failure > case. I don't know how big of a problem this is in practice, since it > requires ovs-vswitchd to become unresponsive.
It sounds like it would be a good idea to prefix them, at least in the long run, but I understand if this is difficult to do quickly. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
