>Hi Bhanu, > >Bhanuprakash Bodireddy <[email protected]> writes: > >> This commit introduces the initial keepalive support by adding >> 'keepalive' module and also helper and initialization functions that >> will be invoked by later commits. >> >> This commit adds new ovsdb column "keepalive". It shows the overall >> datapath status and the health of the cores running datapath threads. >> >> For eg: >> To enable keepalive feature. >> 'ovs-vsctl --no-wait set Open_vSwitch . other_config:enable- >keepalive=true' >> >> To set timer interval of 5000ms for monitoring packet processing cores; >> 'ovs-vsctl --no-wait set Open_vSwitch . \ >> other_config:keepalive-interval="5000" >> >> To set shared memory block name where the events shall be updated >> 'ovs-vsctl --no-wait set Open_vSwitch . >> other_config:keepalive-shm-name="/ovs_keepalive_shm_name"' >> >> Signed-off-by: Bhanuprakash Bodireddy >> <[email protected]> >> --- > >Please drop the shm from this in a future spin. I could break the internal >state >quite easily (like the very first torturous thing I >did) by dumping /dev/urandom to the shared memory file. I could very easily >craft something that will keep this shared memory in a bad state. > >In fact, I haven't even tried to do things like overwrite existing shared >memory >objects (should be possible, and will break other projects, ecryptfs is the >first >that comes to mind). It would be better to just drop it.
Hi Aaron, I agree with you. I have already started working on the code to get rid of SHM. I will wait for few more days to see if there is any more feedback on the remaining patches and will send out new series(v3 - without SHM implementation). Bhanuprakash. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
