Hi Eelco >Hi Bhanu, > >Went over the full patch set, and the changes look good to me. >All my previous concerns are addressed, and therefore I'm acking this series.
Thanks for reviewing the series and acking it. > >I do have one small remark regarding the dpdk_tx_queue struct, see >individual patch email. I agree with what you suggested. I have to send out v2 anyways as Ben suggested to rename the API from netdev_txq_drain() to netdev_txq_flush(). I will factor in your suggestion in V2. > >Here are some numbers with this patch on a none tuned system, single run. >This just to make sure we still benefit with both patches applied. > >Throughput for PV scenario, with 64 byte packets > >Number >flows MASTER With PATCH >====== ========= ========== > 10 4,531,424 7,884,607 > 32 3,137,300 6,367,643 > 50 2,552,725 6,649,985 > 100 2,473,835 5,876,677 > 500 2,308,840 5,265,986 >1000 2,380,755 5,001,081 > > >Throughput for PVP scenario, with 64 byte packets > >Number >flows MASTER With PATCH >====== ========= ========== > 10 2,309,254 3,800,747 > 32 1,626,380 3,324,561 > 50 1,538,879 3,092,792 > 100 1,429,028 2,887,488 > 500 1,271,773 2,537,624 >1000 1,268,430 2,442,405 > >Latency test > > MASTER > ======= > Pkt size min(ns) avg(ns) max(ns) > 512 9,947 12,381 264,131 > 1024 7,662 9,445 194,463 > 1280 7,790 9,115 196,059 > 1518 8,103 9,599 197,646 > > PATCH > ===== > Pkt size min(ns) avg(ns) max(ns) > 512 10,195 12,551 199,699 > 1024 7,838 9,612 206,378 > 1280 8,151 9,575 187,848 > 1518 8,095 9,643 198,552 > > >Throughput for PP scenario, with 64 byte packets: > >Number >flows MASTER With PATCH >====== ========= ========== > 10 7,430,616 8,853,037 > 32 4,770,190 6,774,006 > 50 4,736,259 7,336,776 > 100 4,699,237 6,146,151 > 500 3,870,019 5,242,781 >1000 3,853,883 5,121,911 > > >Latency test > > MASTER > ======= > Pkt size min(ns) avg(ns) max(ns) > 512 4,887 5,596 165,246 > 1024 5,801 6,447 170,842 > 1280 6,355 7,056 159,056 > 1518 6,860 7,634 160,860 > > PATCH > ===== > Pkt size min(ns) avg(ns) max(ns) > 512 4,783 5,521 158,134 > 1024 5,801 6,359 170,859 > 1280 6,315 6,878 150,301 > 1518 6,579 7,398 143,068 > > >Acked-by: Eelco Chaudron <[email protected]> Thanks for your time in testing and sharing the numbers here. Bhanuprakash. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
