On Wed, Jun 14, 2017 at 06:28:17PM +0000, Jan Scheurich wrote:
> > -----Original Message-----
> > From: [email protected]
> > [mailto:[email protected]] On Behalf Of Ben Pfaff
> > Sent: Tuesday, 13 June, 2017 00:29
> > To: [email protected]
> > Cc: Ben Pfaff <[email protected]>
> > Subject: [ovs-dev] [PATCH 11/31] fixup: Wrap docs to 79 columns.
> >
> > Also, OVS really supports the packet-type field in any version, since it
> > accepts OXM even in OpenFlow 1.0.
>
> How does that relate to your earlier fixup (2/31) to make packet_type
> available only in OF1.5? Perhaps we misunderstand the semantics of the
> annotations in meta-flow.h. Are they just for documentation?
Their main purpose is documentation, but when OVS introduces an
extension code point for a field, and then a later version of OpenFlow
adopts a standard code point, the OpenFlow version numbers determine
what code point OVS uses for some particular OpenFlow version. For
example, "tun_id" has the following:
* NXM: NXM_NX_TUN_ID(16) since v1.1.
* OXM: OXM_OF_TUNNEL_ID(38) since OF1.3 and v1.10.
which means that OVS uses its NXM_NX_TUN_ID extension code point for
OpenFlow 1.0 through 1.2, and OXM_OF_TUNNEL_ID for OpenFlow 1.3 an dup.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
