From: Antonio Fischetti <[email protected]> memcpy replaces the single copies inside dp_packet_clone_with_headroom().
Signed-off-by: Antonio Fischetti <[email protected]> --- lib/dp-packet.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 67aa406..5b1d416 100644 --- a/lib/dp-packet.c +++ b/lib/dp-packet.c @@ -157,7 +157,7 @@ dp_packet_clone(const struct dp_packet *buffer) return dp_packet_clone_with_headroom(buffer, 0); } -/* Creates and returns a new dp_packet whose data are copied from 'buffer'. The +/* Creates and returns a new dp_packet whose data are copied from 'buffer'. The * returned dp_packet will additionally have 'headroom' bytes of headroom. */ struct dp_packet * dp_packet_clone_with_headroom(const struct dp_packet *buffer, size_t headroom) @@ -167,13 +167,14 @@ dp_packet_clone_with_headroom(const struct dp_packet *buffer, size_t headroom) new_buffer = dp_packet_clone_data_with_headroom(dp_packet_data(buffer), dp_packet_size(buffer), headroom); - new_buffer->l2_pad_size = buffer->l2_pad_size; - new_buffer->l2_5_ofs = buffer->l2_5_ofs; - new_buffer->l3_ofs = buffer->l3_ofs; - new_buffer->l4_ofs = buffer->l4_ofs; - new_buffer->md = buffer->md; - new_buffer->cutlen = buffer->cutlen; - new_buffer->packet_type = buffer->packet_type; + memcpy(&new_buffer->l2_pad_size, &buffer->l2_pad_size, + sizeof(new_buffer->l2_pad_size) + + sizeof(new_buffer->l2_5_ofs) + + sizeof(new_buffer->l3_ofs) + + sizeof(new_buffer->l4_ofs) + + sizeof(new_buffer->cutlen) + + sizeof(new_buffer->packet_type) + + sizeof(new_buffer->md)); #ifdef DPDK_NETDEV new_buffer->mbuf.ol_flags = buffer->mbuf.ol_flags; #else -- 2.4.11 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
