Hi Ben, >On Mon, Jun 19, 2017 at 07:53:59PM +0100, Bhanuprakash Bodireddy wrote: >> As part of retrieving system statistics, process status APIs along >> with helper functions were implemented. Some of them are very generic >> and can be reused by other subsystems. >> >> Move the APIs in system-stats.c to process.c and util.c and make them >> available. This patch doesn't change any functionality. >> >> CC: Ben Pfaff <[email protected]> >> Signed-off-by: Bhanuprakash Bodireddy >> <[email protected]> > >Thanks for cleaning up the OVS internal APIs. > >Regarding most of these moves, I agree with them. For ticks_to_ms(), >though, I would prefer to keep it in the same place as get_process_info(), and >as a static function, because I don't envision it being called from anywhere >else. Are you OK making that change?
Posted v2 with what you suggested here. (Moved ticks_to_ms() to process.c and made it static function.) V2: https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/334362.html Bhanuprakash. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
