On 21 June 2017 at 15:30, Yi-Hung Wei <[email protected]> wrote: > Thanks for the patch. I think it does address the aforementioned issue. > The testcase may not verify the action re-encoding. We can always > figure out a new testcase and an easier way to verify action re-encoding > later on. > > Acked-by: Yi-Hung Wei <[email protected]>
I thought so too about the verification of action re-encoding, but then I reverted the core change and kept the test, and I found that the test actually fails otherwise. See here: https://github.com/openvswitch/ovs/blob/v2.7.0/utilities/ovs-ofctl.c#L3930 /* "parse-actions VERSION": reads a series of action specifications for the * given OpenFlow VERSION as hex bytes from stdin, converts them to ofpacts, * prints them as strings on stdout, and then converts them back to hex bytes * and prints any differences from the input. */ Thanks for the review, applied to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
