On Mon, Jul 03, 2017 at 02:27:18PM +0000, Zoltán Balogh wrote:
> By introducing packet type-aware pipeline, match on ethertype was
> removed when packet type is not Ethernet. As pointed out by Eric Garver,
> this could have a side effect on the kernel datapath:
> https://patchwork.ozlabs.org/patch/782991/
> 
> This patch does approach the problem from a different perspective.
> Instead of re-introducing the unconditional match on Ethernet type in all
> megaflow entries, as suggested by Eric, mapping of packet_type != PT_ETH to
> dl_type could be handled in the put_exclude_packet_type() in dpif-netlink.c.
> 
> Put_exclude_packet_type() filters the packet_type netlink attribute out,
> before all attributes are sent from userspace to kernel. This commit modifies
> the put_exclude_packet_type() function to do a proper conversation and add the
> missing OVS_KEY_ATTR_ETHERTYPE attribute if it's needed.
> 
> Signed-off-by: Zoltán Balogh <[email protected]>
> Reported-by: Eric Garver <[email protected]>
> ---
>  lib/dpif-netlink.c | 34 ++++++++++++++++++++++++++++------
>  1 file changed, 28 insertions(+), 6 deletions(-)
> 

[..]

This patch's subject has a typo. s/dpif-netilnk/dpif-netlink/
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to