On Thu, Jul 06, 2017 at 09:00:50PM -0400, Russell Bryant wrote: > On Thu, Jul 6, 2017 at 6:12 PM, Ben Pfaff <[email protected]> wrote: > > flake8 checking is useful. Until now, it always failed the build for any > > flake8 errors. This is too aggressive, for the same reason that always > > failing the build for any compiler warnings is too aggressive: compilers > > change over time and asynchronously from OVS itself. Thus, if we release > > some version of OVS today, even if it's flake8-clean today, it might not > > be flake8-clean tomorrow, even with the same settings. We don't want to > > have to track flake8 warnings on every release branch. > > > > Thus, this adopts the same policy for compiler warnings: always report > > them, but only fail the build if --enable-Werror was configured. Usually > > just developers use that configure option, and they're prepared to deal > > with the fallout. > > > > Signed-off-by: Ben Pfaff <[email protected]> > > > Acked-by: Russell Bryant <[email protected]>
Thanks, applied to master, branch-2.7, and branch-2.6. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
