On 4 Jan 2026, at 8:28, Eli Britstein wrote:
> On 02/01/2026 15:30, Eelco Chaudron wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 1 Jan 2026, at 16:49, Eli Britstein via dev wrote:
>>
>>> On 02/12/2025 16:05, Eelco Chaudron wrote:
>>>> This change adds the full name to the dp_netdev structure,
>>>> required by the next patch.
>>> squash it to the next patch then.
>> I left this as a separate patch for v3, as the next patch is already quite
>> large.
>> We can squash it into the next revision if really necessary.
>
> Though it is not critical, this commit is quite small so it wouldn't make
> much difference for the next one.
>
> Also, the justification for a separate commit of "required for the next one"
> is not sufficient IMO.
ACK, will merge in v4.
>>
>> [...]
>>
>>>> Signed-off-by: Eelco Chaudron <[email protected]>
>>>> ---
>>>> lib/dpif-netdev.c | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>>>> index 2aeef471f..6324cfb7a 100644
>>>> --- a/lib/dpif-netdev.c
>>>> +++ b/lib/dpif-netdev.c
>>>> @@ -271,6 +271,7 @@ enum sched_assignment_type {
>>>> struct dp_netdev {
>>>> const struct dpif_class *const class;
>>>> const char *const name;
>>>> + const char *const full_name;
>>>> struct ovs_refcount ref_cnt;
>>>> atomic_flag destroyed;
>>>> @@ -1886,6 +1887,8 @@ create_dp_netdev(const char *name, const struct
>>>> dpif_class *class,
>>>> *CONST_CAST(const struct dpif_class **, &dp->class) = class;
>>>> *CONST_CAST(const char **, &dp->name) = xstrdup(name);
>>>> + *CONST_CAST(const char **, &dp->full_name) = xasprintf("%s@%s",
>>>> + class->type,
>>>> name);
>>>> ovs_refcount_init(&dp->ref_cnt);
>>>> atomic_flag_clear(&dp->destroyed);
>>>> @@ -2054,6 +2057,7 @@ dp_netdev_free(struct dp_netdev *dp)
>>>> free(dp->max_sleep_list);
>>>> free(dp->pmd_cmask);
>>>> free(CONST_CAST(char *, dp->name));
>>>> + free(CONST_CAST(char *, dp->full_name));
>>>> free(dp);
>>>> }
>>>>
>>> _______________________________________________
>>> dev mailing list
>>> [email protected]
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
