On 13 Jan 2026, at 21:26, Ilya Maximets wrote:
> On 1/12/26 12:20 PM, Eelco Chaudron wrote: >> This patch adds a new API that allows offload providers >> to expose free-form debug information. The information >> can be used for troubleshooting the offload providers state. >> >> The new API is integrated into the existing >> 'ovs-appctl dpif/offload/show' command, which now >> displays this debug output when available. >> >> Support for this API has been implemented for all >> currently supported offload providers. >> >> Acked-by: Eli Britstein <elibr.nvidia.com> >> Signed-off-by: Eelco Chaudron <[email protected]> >> --- Thanks for the review. All comments will be addressed in v6. [...] >> -AT_CHECK([ovs-appctl dpif/offload/show], [0], [dnl >> +sort_dpif_offload_show () { >> + dnl Note: We do not use an m4 macro as it does not like the $0, or >> escaped >> + dnl variants and loops until it runs out of memory. > > Note: I think, the $[0] should work as the m4 pass will remove the brackets > and should not evaluate further. But it's OK to use a shell function for > filtering. Just the comment may be a bit inaccurate. I remember trying tons of stuff here and eventually gave up. I’ll remove the comment anyway. >> + awk ' >> + /^ -/ { dashlines[[++n]] = $0; next } >> + { print } >> + END { >> + asort(dashlines) >> + for (i=1; i<=n; i++) print dashlines[[i]] >> + } >> + ' | sed -E 's/ifindex: [[0-9]]+/ifindex: 0/g' >> +} [...] _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
