On 14 Jan 2026, at 13:20, Ilya Maximets wrote:

> On 1/12/26 12:20 PM, Eelco Chaudron wrote:
>> Add flow control API calls to the dummy offload provider, enabling
>> the re-addition of previously disabled partial offload tests.
>>
>> Acked-by: Eli Britstein <elibr.nvidia.com>
>> Signed-off-by: Eelco Chaudron <[email protected]>
>> ---
>>
>> v2 changes:
>>   - Fix indentation in dpif_offload_dummy_cleanup_flow_pmd_data().
>>   - Renamed remote_from_port to remove_from_port variable.
>>
>> v3 changes:
>>   - Fixed partial hardware offload flow lookup, i.e. it was missing
>>     the netdev_hw_post_process() API.
>> ---
>>  lib/dpif-offload-dummy.c | 659 +++++++++++++++++++++++++++++++++++++--
>>  lib/dummy.h              |   6 +
>>  lib/netdev-dummy.c       |   4 +-
>>  tests/dpif-netdev.at     |  52 +--
>>  4 files changed, 669 insertions(+), 52 deletions(-)
>>
>
> <snip>
>
>> +static void
>> +dpif_offload_dummy_register_flow_unreference_cb(
>> +    const struct dpif_offload *offload_, dpif_offload_flow_unreference_cb 
>> *cb)
>> +{
>> +    struct dpif_offload_dummy *offload = dpif_offload_dummy_cast(offload_);
>> +
>> +    offload->unreference_cb = cb;
>> +}
>> +
>> +static void
>> +dpif_offload_dummy_flow_unreference(struct dpif_offload_dummy *offload,
>> +                                    unsigned pmd_id, void *flow_reference)
>> +{
>> +    if (offload->unreference_cb) {
>> +        offload->unreference_cb(pmd_id, flow_reference);
>> +    }
>> +}
>> +
>> +void
>> +dpif_offload_dummy_netdev_simulate_offload(struct netdev *netdev,
>> +                                           struct dp_packet *packet,
>> +                                           struct flow *flow)
>> +{
>> +    const struct dpif_offload *offload_ = ovsrcu_get(
>
> I missed one more hit here:
> No need for underscore for this variable.

Ack, fixed in v6.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to