On 1/20/26 2:26 PM, Eelco Chaudron wrote: > Mass rename of offload provider structures and functions to improve > coherence and readability. Most of these symbols are local and > not exported, so they do not require extensive prefixes. > > Signed-off-by: Eelco Chaudron <[email protected]> > --- > > v2: Incorporate Ilya's review comments. > --- > lib/dpif-offload-dpdk-netdev.c | 280 +++++++++----------- > lib/dpif-offload-dpdk-private.h | 71 +++--- > lib/dpif-offload-dpdk.c | 358 ++++++++++++-------------- > lib/dpif-offload-dummy.c | 439 ++++++++++++++------------------ > lib/dpif-offload-tc-netdev.c | 68 +++-- > lib/dpif-offload-tc-private.h | 51 ++-- > lib/dpif-offload-tc.c | 316 +++++++++++------------ > lib/dummy.h | 5 +- > lib/netdev-dummy.c | 2 +- > 9 files changed, 729 insertions(+), 861 deletions(-)
Thanks for v2! I didn't test it much, but the change looks good in general. See two nits below that could be fixed on commit. With that addressed: Acked-by: Ilya Maximets <[email protected]> > diff --git a/lib/dpif-offload-dpdk.c b/lib/dpif-offload-dpdk.c > index 3f7404d2d..ffae3ac5d 100644 > --- a/lib/dpif-offload-dpdk.c > +++ b/lib/dpif-offload-dpdk.c > @@ -707,21 +692,18 @@ dpif_offload_dpdk_get_netdev(const struct > dpif_offload_dpdk *offload, > } > > static struct netdev * > -dpif_offload_dpdk_get_netdev_(struct dpif_offload *offload_, > - odp_port_t port_no) > +dpdk_offload_get_netdev_(struct dpif_offload *offload_, odp_port_t port_no) Should add a second underscore for the function name here. > { > - struct dpif_offload_dpdk *offload = dpif_offload_dpdk_cast(offload_); > + struct dpdk_offload *offload = dpdk_offload_cast(offload_); > > - return dpif_offload_dpdk_get_netdev(offload, port_no); > + return dpdk_offload_get_netdev(offload, port_no); > } > > static int > -dpif_offload_dpdk_open(const struct dpif_offload_class *offload_class, > - struct dpif *dpif, struct dpif_offload **offload_) > +dpdk_offload_open(const struct dpif_offload_class *offload_class, > + struct dpif *dpif, struct dpif_offload **offload_) > { > - struct dpif_offload_dpdk *offload; > - > - offload = xmalloc(sizeof *offload); > + struct dpdk_offload *offload = xmalloc(sizeof *offload); > > dpif_offload_init(&offload->offload, offload_class, dpif); > offload->port_mgr = dpif_offload_port_mgr_init(); <snip> > diff --git a/lib/dpif-offload-dummy.c b/lib/dpif-offload-dummy.c > index 519aad56e..be1b62f97 100644 > --- a/lib/dpif-offload-dummy.c > +++ b/lib/dpif-offload-dummy.c > @@ -786,39 +747,37 @@ dpif_offload_dummy_netdev_flow_stats(const struct > dpif_offload *offload_, > } > > static void > -dpif_offload_dummy_register_flow_unreference_cb( > - const struct dpif_offload *offload_, dpif_offload_flow_unreference_cb > *cb) > +dummy_register_flow_unreference_cb(const struct dpif_offload *offload_, > + dpif_offload_flow_unreference_cb *cb) > { > - struct dpif_offload_dummy *offload = dpif_offload_dummy_cast(offload_); > + struct dummy_offload *offload = dummy_offload_cast(offload_); > > offload->unreference_cb = cb; > } > > static void > -dpif_offload_dummy_flow_unreference(struct dpif_offload_dummy *offload, > - unsigned pmd_id, void *flow_reference) > +dummy_flow_unreference(struct dummy_offload *offload, unsigned pmd_id, > + void *flow_reference) > { > if (offload->unreference_cb) { > offload->unreference_cb(pmd_id, flow_reference); > } > } > > -void > -dpif_offload_dummy_netdev_simulate_offload(struct netdev *netdev, > - struct dp_packet *packet, > - struct flow *flow) > +void dummy_netdev_simulate_offload(struct netdev *netdev, The name should be on a separate line. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
