On 12/19/25 10:48 AM, Alexandra Rukomoinikova wrote:
> 1) Refactor service monitor related code to separate function to avoid
>    code duplication.
> 
> 2) Added LSP health check handling for service monitors.
> 
> Signed-off-by: Alexandra Rukomoinikova <[email protected]>
> ---

Hi Alexandra,

Thanks for the patch!  On top of Mark's comments I have one of my own.

>  northd/en-northd.c               |   2 +
>  northd/inc-proc-northd.c         |   5 +-
>  northd/northd.c                  | 303 +++++++++++++++++++++++++------
>  northd/northd.h                  |   3 +
>  tests/ovn-inc-proc-graph-dump.at |   2 +
>  5 files changed, 263 insertions(+), 52 deletions(-)

We should probably add some ovn-northd.at tests to validate
creation/deletion/etc of service monitors in the SB for logical switch
ports with healthcheck enabled.

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to