Bleep bloop. Greetings Matteo Perin, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#42 FILE: lib/netdev-linux-private.h:100:
uint64_t peer_ifindex; /* Cached from ETHTOOL_GSTATS (veth only).
*/
WARNING: Line is 80 characters long (recommended limit is 79)
#62 FILE: lib/netdev-linux.c:3739:
/* For veth devices, also get the peer_ifindex via ETHTOOL_GSTATS */
WARNING: Line is 89 characters long (recommended limit is 79)
#63 FILE: lib/netdev-linux.c:3740:
if (!strcmp(netdev->drvinfo.driver, "veth") &&
netdev->drvinfo.n_stats > 0) {
WARNING: Line is 82 characters long (recommended limit is 79)
#64 FILE: lib/netdev-linux.c:3741:
/* Dynamically allocate based on n_stats from ETHTOOL_GDRVINFO.
*/
WARNING: Line is 89 characters long (recommended limit is 79)
#66 FILE: lib/netdev-linux.c:3743:
size_t req_size = sizeof(struct ethtool_stats) + sizeof(__u64)
* n_stats;
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#71 FILE: lib/netdev-linux.c:3748:
ERROR: Inappropriate spacing around cast
#73 FILE: lib/netdev-linux.c:3750:
(struct ethtool_cmd *)req,
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#81 FILE: lib/netdev-linux.c:3758:
WARNING: Line is 83 characters long (recommended limit is 79)
#94 FILE: lib/netdev-linux.c:3771:
smap_add_format(smap, "peer_ifindex", "%"PRIu64,
netdev->peer_ifindex);
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
