Hello, On Sun, 25 Jan 2026 at 10:39, Dmitry Mityugov <[email protected]> wrote: > > Array impl_set_masked_funcs is defined in lib/odp-execute-avx512.c > without static modifier but isn't used outside of this module. Recent > versions of GCC can be instructed to deliver warnings for such cases, > with -Wmissing-variable-declarations compiler option enabled. The > problem in question can be reproduced with > > ./configure --enable-Werror CFLAGS="-Wmissing-variable-declarations" && make > > To fix the problem, the array should be defined as static. This problem > can be reproduced only on 64-bit x86 machines, not on ARM/RISC-V.
That's expected, as AVX512 only makes sense for x86_64. > Signed-off-by: Dmitry Mityugov <[email protected]> Thanks, I can reproduce the issue and the fix looks correct. I have some nits on the patch title which is too generic (this can probably be fixed when a maintainer applies the patch). A patch subject should start with a prefix reflecting what part of OVS is being touched. So here, "odp-execute: " (in doubt, I figure this out by looking at the git history for the files changed by a patch). I prefer when the title helps figuring out quickly what was broken, and in which circumstance. And I think you meant GCC 15. So I would suggest something like: odp-execute: Fix build with GCC 15 with AVX512. > --- > Huge thanks to everyone who helped me fix the email with the original > patch. Hopefully it will be accepted this time. > > Not sure about the address this patch should be sent to. Page > https://mail.openvswitch.org/mailman/listinfo/ovs-dev says to use > [email protected] whereas this guide > https://docs.openvswitch.org/en/latest/internals/contributing/submitting-patches/ > recommends [email protected] You can send to [email protected] in general. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
