Hi Ketan,
This is not a comprehensive review but I just wanted to point out one
nit I noticed while looking it over.
On 1/27/26 3:55 PM, Ketan Supanekar via dev wrote:
<snip>
> +# Total queries should be > 0
> +OVS_WAIT_FOR_OUTPUT([ovn-appctl coverage/read-counter dhcp_query_total | awk
> '{if ($1 > 0) print "ok"}'], [0], [ok
> +])
> +# SOLICIT messages should be > 0
> +OVS_WAIT_FOR_OUTPUT([ovn-appctl coverage/read-counter dhcp_v6_solicit | awk
> '{if ($1 > 0) print "ok"}'], [0], [ok
> +])
> +# RELEASE messages should be > 0
> +OVS_WAIT_FOR_OUTPUT([ovn-appctl coverage/read-counter dhcp_v6_release | awk
> '{if ($1 > 0) print "ok"}'], [0], [ok
> +])
> +# INFO_REQUEST messages should be > 0
> +OVS_WAIT_FOR_OUTPUT([ovn-appctl coverage/read-counter dhcp_v6_info_request |
> awk '{if ($1 > 0) print "ok"}'], [0], [ok
> +])
> +# ADVERTISE responses should be > 0
> +OVS_WAIT_FOR_OUTPUT([ovn-appctl coverage/read-counter dhcp_v6_advertise_sent
> | awk '{if ($1 > 0) print "ok"}'], [0], [ok
> +])
> +# REPLY responses should be > 0
> +OVS_WAIT_FOR_OUTPUT([ovn-appctl coverage/read-counter dhcp_v6_reply_sent |
> awk '{if ($1 > 0) print "ok"}'], [0], [ok
> +])
Rather than printing and then checking for "ok", it's easier to just do:
> OVS_WAIT_UNTIL([test $(ovn-appctl coverage/read-counter dhcp_query_total) -gt
> 0])
Take care!
--
Rosemarie O'Riorden
Lowell, MA, United States
[email protected]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
