On Mon, Feb 2, 2026 at 10:12 PM Jacob Tanenbaum <[email protected]> wrote:
> > > On Mon, Feb 2, 2026 at 4:00 AM Ales Musil via dev <[email protected]> > wrote: > >> If there is a wrong value specified INFO might be too quiet for >> anyone to notice. Change it to WARN. >> >> Signed-off-by: Ales Musil <[email protected]> >> --- >> controller/lflow.c | 2 +- >> tests/ovn.at | 8 ++++++-- >> 2 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/controller/lflow.c b/controller/lflow.c >> index bab422a9c..94fd8807c 100644 >> --- a/controller/lflow.c >> +++ b/controller/lflow.c >> @@ -3020,7 +3020,7 @@ consider_port_sec_flows(const struct >> sbrec_port_binding *pb, >> &ps_addrs[n_ps_addrs])) { >> static struct vlog_rate_limit rl >> = VLOG_RATE_LIMIT_INIT(1, 1); >> - VLOG_INFO_RL(&rl, "invalid syntax '%s' in port " >> + VLOG_WARN_RL(&rl, "invalid syntax '%s' in port " >> "security. No MAC address found", >> pb->port_security[i]); >> continue; >> diff --git a/tests/ovn.at b/tests/ovn.at >> index 52d47e36b..e9e754a0a 100644 >> --- a/tests/ovn.at >> +++ b/tests/ovn.at >> @@ -13780,7 +13780,8 @@ test_ipv6_ra 1 $src_mac $src_lla "$ra" 1500 "" "" >> "" "" >> $PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv1/vif1-tx.pcap > >> 1.packets >> AT_CHECK([cat 1.packets], [0], []) >> >> -OVN_CLEANUP([hv1]) >> +OVN_CLEANUP([hv1 >> +/invalid syntax '' in port security/d]) >> AT_CLEANUP >> ]) >> >> @@ -35880,7 +35881,9 @@ check_port_sec_offlows hv2 >> OFTABLE_CHK_OUT_PORT_SEC >> # sw0 not local to hv1 as sw0p2 and hv1-vif0 are deleted >> # sw0 not local to hv2 as sw0p2 has been deleted. >> OVN_CLEANUP([hv1 >> +/invalid syntax '' in port security/d >> ignored_dp=sw0], [hv2 >> +/invalid syntax '' in port security/d >> > > Is there a reason that the port security could not be added correctly? > That test is adding empty string as port security on purpose. > >> ignored_dp=sw0]) >> AT_CLEANUP >> ]) >> @@ -41061,7 +41064,8 @@ dnl Make sure that the packet was received by vm0. >> echo $packet >> expected-vif1 >> OVN_CHECK_PACKETS([hv/vif1-tx.pcap], [expected-vif1]) >> >> -OVN_CLEANUP([hv]) >> +OVN_CLEANUP([hv >> +/invalid syntax '' in port security/d]) >> AT_CLEANUP >> ]) >> >> -- >> 2.52.0 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> Regards, Ales _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
