On Fri, Jun 23, 2017 at 01:28:22PM +0100, [email protected] wrote:
> From: Antonio Fischetti <[email protected]>
>
> With the command:
> ovs-appctl dpctl/ct-bkts
> shows the number of connections per bucket.
>
> By using a threshold:
> ovs-appctl dpctl/ct-bkts gt=N
> for each bucket shows the number of connections when they
> are greater than N.
>
> Signed-off-by: Antonio Fischetti <[email protected]>
> Signed-off-by: Bhanuprakash Bodireddy <[email protected]>
> Co-authored-by: Bhanuprakash Bodireddy <[email protected]>
Thanks for the patch!
checkpatch reports a few style issues:
WARNING: Line length is >79-characters long
#145 FILE: lib/dpctl.c:1529:
dpctl_print(dpctl_p, "\n %3d..%3d | ", i, i +
NUM_BKTS_PER_ROW - 1);
ERROR: Inappropriate bracing around statement
#147 FILE: lib/dpctl.c:1531:
if (conn_per_bkts[i] > gt)
Is this concept of buckets one that the kernel conntracker has too? If
so, then I'm concerned about the definition of conn_per_buckets[] in
dpctl_ct_bkts(), since it has a hardcoded CONNTRACK_BUCKETS size and
nothing checks whether cte.bkt is in the right range. If not, then
should this command be one that is limited to the userspace conntracker?
I'd update NEWS to describe the new command.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
