On 2/6/26 4:57 PM, Eelco Chaudron wrote:
> Move port manager instances from provider-specific data structures
> into the common struct dpif_offload. This removes duplication across
> providers and clarifies ownership of port-related state.
> 
> With the port manager owned by dpif_offload, offload providers are
> required to use the common port management APIs. This simplifies
> external port management and eliminates the need for provider-specific
> port enumeration logic.
> 
> The port dump functions were also simplified using the
> CMAP_CURSOR_FOR_EACH_CONTINUE() API.

nit: This part seems outdated.

> 
> Signed-off-by: Eelco Chaudron <[email protected]>
> ---
> 
> v2: Addresses Ilya's comments.
> v3: Rebase to latest upstream.
> v4: Removed the dpif_offload_port_dump_* interface.
> ---
>  lib/dpif-offload-dpdk-netdev.c |   5 +-
>  lib/dpif-offload-dpdk.c        | 107 ++++-------
>  lib/dpif-offload-dummy.c       |  94 +++-------
>  lib/dpif-offload-provider.h    |  70 +++-----
>  lib/dpif-offload-tc-netdev.c   |   5 +-
>  lib/dpif-offload-tc.c          | 114 ++++--------
>  lib/dpif-offload.c             | 313 +++++++++------------------------
>  lib/dpif-offload.h             |  32 +---
>  8 files changed, 212 insertions(+), 528 deletions(-)
Thanks, Eelco!

I didn't test it much, but it looks good to me in general.  In particular
removal of 300+ lines. :)

Acked-by: Ilya Maximets <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to