> From: "Ben Pfaff" <[email protected]> > To: "Lance Richardson" <[email protected]> > Cc: [email protected], [email protected], "javier albornoz" > <[email protected]>, "jorge sauma" > <[email protected]>, "arnoldo lutz guevara" <[email protected]> > Sent: Tuesday, 11 July, 2017 4:18:46 PM > Subject: Re: [ovs-dev] [PATCH v5 2/4] lib: skiplist implementation > > On Sat, Jun 24, 2017 at 05:01:50PM -0400, Lance Richardson wrote: > > Skiplist implementation intended for use in the IDL compound indexes > > feature. > > > > Signed-off-by: Esteban Rodriguez Betancourt <[email protected]> > > Co-authored-by: Lance Richardson <[email protected]> > > Signed-off-by: Lance Richardson <[email protected]> > > Thanks for reviving this series. > > I have a few style suggestions, see the following incremental. > > My only concern here is the following declaration in skiplist_insert() > and skiplist_delete(). Because of the semantics of initialization in C, > this means that, on a 64-bit system, this will always memset 33*8 == 264 > bytes of memory to zero on each invocation. Can we avoid the > initialization? > > struct skiplist_node *update[SKIPLIST_MAX_LEVELS + 1] = { NULL }; >
These initializations are unnecessary, skiplist_forward_to__() will set the entries that need to be set. I will remove these, fold in your incremental, and repost. Thanks, Lance > Thanks, > > Ben. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
