On 2/18/26 5:06 PM, Rukomoinikova Aleksandra wrote:
> On 18.02.2026 18:35, Dumitru Ceara wrote:
>>
>> Hi Alexandra,
>>
>> On 2/17/26 6:58 PM, Alexandra Rukomoinikova wrote:
>>> +static bool
>>> +svc_monitor_matches_health_check(const struct sbrec_service_monitor
>>> *sbrec_mon,
>>> + const char *protocol,
>>> + const char *src_ip,
>>> + const char *target_ip,
>>> + uint16_t destination_port)
>>> +{
>>> + if (strcmp(sbrec_mon->protocol, protocol) != 0) {
>>> + return false;
>>> + }
>>> +
>>> + if (!strcmp(protocol, "tcp") || !strcmp(protocol, "udp")) {
>>> + if (sbrec_mon->port != destination_port) {
>>> + return false;
>>> + }
>>> + }
>>> +
>>> + if (!strcmp(sbrec_mon->src_ip, src_ip)) {
>>> + return true;
>>> + }
>>> +
>>> + if (!strcmp(sbrec_mon->ip, target_ip)) {
>>> + return true;
>>> + }
>>> +
>>> + return false;
>>> +}
>>
>> This seems wrong, and I thought I mentioned it in the previous version.
>>
>> Shouldn't it be?
>>
>> + if (strcmp(sbrec_mon->src_ip, src_ip)) {
>> + return false;
>> + }
>> +
>> + if (strcmp(sbrec_mon->ip, target_ip)) {
>> + return false;
>> + }
>> +
>> + return true;
>>
>> Or am I missing something?
>>
>> Thanks,
>> Dumitru
>>
> Hi! Oh, God, yeah.... I didn't notice, sorry(
>
No worries, I just wanted to make sure I didn't misunderstand the intention.
Thanks!
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
