The callback to clear tracked data cast the hmapx node's data to a northbound logical router instead of a northbound logical switch. The only operation performed on the pointer is to free it, so this did not cause any catastrophic errors. However, if this were to be altered in some meaningful way, this could cause a problem.
This commit fixes the callback to cast the hmapx node data to the correct type. Signed-off-by: Mark Michelson <[email protected]> --- northd/en-datapath-logical-switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/northd/en-datapath-logical-switch.c b/northd/en-datapath-logical-switch.c index ef4c95d28..afe72003d 100644 --- a/northd/en-datapath-logical-switch.c +++ b/northd/en-datapath-logical-switch.c @@ -405,8 +405,8 @@ en_datapath_synced_logical_switch_clear_tracked_data(void *data) struct hmapx_node *node; HMAPX_FOR_EACH_SAFE (node, &switch_map->deleted) { - struct ovn_synced_logical_router *lr = node->data; - free(lr); + struct ovn_synced_logical_switch *ls = node->data; + free(ls); hmapx_delete(&switch_map->deleted, node); } } -- 2.52.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
