On 2/25/26 08:49, Panos Kostopoulos Kyrimis via dev wrote:
> ovn-ctl stop_ovnbr_ovsdb was introduced as an available option,
> but was never implemented in the ovn-ctl executable. This patch
> introduces its implementation.
> 
> Fixes: 22dbd8021359 ("ovn-ctl: Add commands to start OVN bridge controller 
> services.")
> Reported-at: https://bugs.launchpad.net/bugs/2142197
> Signed-off-by: Panos Kostopoulos Kyrimis 
> <[email protected]>

Hello, Panos, and thanks for the patch!

I went ahead and tried this out, and it works as expected.


> ---
>  utilities/ovn-ctl | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
> index 3fb2a4413..2764c714c 100755
> --- a/utilities/ovn-ctl
> +++ b/utilities/ovn-ctl
> @@ -88,6 +88,10 @@ stop_sb_relay_ovsdb() {
>      OVS_RUNDIR=${OVS_RUNDIR} stop_ovn_daemon ovnsb_relay 
> $DB_SB_RELAY_PIDFILE $DB_SB_RELAY_CTRL_SOCK
>  }
> 
> +stop_ovnbr_ovsdb () {
> +    OVS_RUNDIR=${OVS_RUNDIR} stop_ovn_daemon ovnbr_db $DB_OVNBR_PIDFILE 
> $DB_OVNBR_CTRL_SOCK

As we discussed oob, this gives a long line warning, but since it matches local 
style, so I think that would be acceptable.

Reviewed-by: Frode Nordahl <[email protected]>

-- 
Frode Nordahl


> +}
> +
>  demote_xx_ovsdb () {
>      local sync_from_addr=$1
>      local sync_from_proto=$2
> --
> 2.43.0
> 
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev



_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to