Re: [ovs-dev] [PATCH 10/13] dpif-netdev: Fix race on static_tx_qid in pmd_alloc_static_tx_qid().

[Eelco Chaudron via dev]

On 26 Feb 2026, at 11:40, Eelco Chaudron via dev wrote:

> Coverity reports a data race where pmd_alloc_static_tx_qid() accesses
> pmd->static_tx_qid in the VLOG_DBG() call without holding the
> tx_qid_pool_mutex, while id_pool_alloc_id() writes to static_tx_qid
> with the mutex held.
>
> The race occurs because the VLOG_DBG() call is placed after the mutex
> unlock. While this is a debug-only log with minimal practical impact,
> it violates proper locking discipline and could theoretically read a
> stale or inconsistent value.
>
> Fix by moving the VLOG_DBG() call before the mutex unlock, ensuring
> the read of static_tx_qid is protected by the same lock that protects
> the write.
>
> Fixes: 140dd699463a ("dpif-netdev: Incremental addition/deletion of PMD 
> threads.")
> Signed-off-by: Eelco Chaudron <echau...@redhat.com>

Recheck-request: github-robot

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev