On 2/27/26 1:56 AM, Jakub Kicinski wrote:
> On Thu, 26 Feb 2026 14:10:54 -0800 Randy Dunlap wrote:
>> + /* private: */
>> OVS_DP_ATTR_UNSPEC,
>> + /* public: */
>
> Hm, can't quickly grep the relevant guidance but I always thought that
> the comment is supposed to pretend to be a label. IOW not be indented:
>
> enum ovs_datapath_attr {
> /* private: */
> OVS_DP_ATTR_UNSPEC,
> /* public: */
> OVS_DP_ATTR_NAME, /* name of dp_ifindex netdev */
>
> I find that easier to read, but no strong preference.
FWIW, it looks like ynl puts the private tag on the same indentation
level as the max enum member, which we can see in the generated headers:
https://lore.kernel.org/all/[email protected]/
But I also do not have a strong opinion on how it should look like.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
