Hi Ilya,
Thanks for your careful review of these changes.
On 2/28/26 9:55 AM, Ilya Maximets wrote:
> On 2/28/26 2:00 AM, Randy Dunlap wrote:
>>
>> include/uapi/linux/openvswitch.h | 72 ++++++++++++++++++++++++++---
>> 1 file changed, 65 insertions(+), 7 deletions(-)
>>
>> --- linux-next-20260227.orig/include/uapi/linux/openvswitch.h
>> +++ linux-next-20260227/include/uapi/linux/openvswitch.h
>> @@ -291,12 +313,13 @@ enum ovs_vport_attr {
>>
>> /**
>> * enum ovs_vport_upcall_attr - attributes for %OVS_VPORT_UPCALL* commands
>
> Not a problem of this patch, but this line is also wrong, there are no
> such commands. These are attributes for OVS_VPORT_ATTR_UPCALL_STATS.
I corrected that.
>> @@ -652,6 +681,8 @@ enum ovs_flow_attr {
>> * %UINT32_MAX samples all packets and intermediate values sample
>> intermediate
>> * fractions of packets.
>> * @OVS_SAMPLE_ATTR_ACTIONS: Set of actions to execute in sampling event.
>> + * @OVS_SAMPLE_ATTR_ARG: same as @OVS_SAMPLE_ATTR_PROBABILITY, for in-kernel
>> + * use, passing &struct sample_arg.
>
> I wouldn't call it 'the same', more like 'extended', or just omit that part of
> the description, keeping only what's after the comma. Or maybe "For in-kernel
> use, passing &struct sample_arg derived from other attributes.".
>
>> * Actions are passed as nested attributes.
>
> This line belongs to OVS_SAMPLE_ATTR_ACTIONS.
OK, moved it.
>> * @OVS_ACTION_ATTR_PUSH_MPLS: Push a new MPLS label stack entry onto the
>> * top of the packets MPLS label stack. Set the ethertype of the
>> * encapsulating frame to either %ETH_P_MPLS_UC or %ETH_P_MPLS_MC to
>> @@ -997,6 +1050,7 @@ enum ovs_psample_attr {
>> * start of the packet or at the start of the l3 header depending on the
>> value
>> * of l3 tunnel flag in the tun_flags field of OVS_ACTION_ATTR_ADD_MPLS
>> * argument.
>> + * @OVS_ACTION_ATTR_DEC_TTL: Nested OVS_DEC_TTL_ATTR_* action.
>
> "Decreate TTL or hop limit of the packet. Execute nested %OVS_DEC_TTL_ATTR_*
Decrement
?
> actions if the value is less or equal to 1."
thanks.
--
~Randy
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
