On 2/26/26 5:24 PM, David Marchand wrote:
> Currently, if one incorrect mac is set, a first log with little context
> is displayed, followed by a more complete one.
> 
> Besides, if no port can be identified with the passed mac, then no
> explanation is displayed.
> 
> Report some details in a single log.
> 
> Before:
> netdev_dpdk|ERR|invalid mac: 00:00:00:00:00:
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:'
>       to DPDK
> ...
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:00'
>       to DPDK
> 
> After:
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:'
>       to DPDK: invalid mac
> ...
> netdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:00'
>       to DPDK: unknown mac
> 
> Signed-off-by: David Marchand <[email protected]>
> Acked-by: Eli Britstein <[email protected]>
> Acked-by: Eelco Chaudron <[email protected]>

LGTM. I will ack next version as Ilya had some changes requested.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to