On 3/19/26 1:23 PM, Ales Musil wrote: > > > On Thu, Mar 19, 2026 at 11:02 AM Dumitru Ceara via dev <ovs- > [email protected] <mailto:[email protected]>> wrote: > > It doesn't really make sense to use the router port MAC as service > monitor source otherwise. Worse, it may even break existing use cases > when the load balancer is only applied to logical switches and not to > the routers connected to them. > > In order for the change to work properly we also had to fallback to > recompute in all cases when load balancers with health check > configuration are added/updated/deleted (through load balancer groups > too). This was currently not happening but didn't really cause issues > before ceea1d7cccad ("northd: Allow LB health checks from router IPs."). > > This also uncovered a bug in pinctrl, where we don't resync the > in-memory version of the service monitor if the SB contents change > (e.g., the source mac address). The patch fixes that part too as it > wasn't especially visible until now when we change the source mac of the > monitor if it gets applied to a router and uses the router IP. > > Fixes: a0a5dd8ce56f ("controller: Store src_mac, src_ip in > svc_monitor struct.") > Fixes: ceea1d7cccad ("northd: Allow LB health checks from router IPs.") > Reported-at: https://redhat.atlassian.net/browse/FDP-3453 <https:// > redhat.atlassian.net/browse/FDP-3453> > Signed-off-by: Dumitru Ceara <[email protected] > <mailto:[email protected]>> > --- > > > Hi Dumitru, >
Hi Ales, > thank you for the v2. Just one thing, let's split the patch into two > each fixing one issue. With that done: > > Acked-by: Ales Musil <[email protected] <mailto:[email protected]>> > You're right, it's better to split them. I posted v3. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
